Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use HardSourceWebpackPlugin #5567

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add option to use HardSourceWebpackPlugin #5567

merged 1 commit into from
Oct 31, 2019

Conversation

acid-chicken
Copy link
Member

Summary

Resolve #5498
CC: @MarchWorks

Set a truthy value to a machine environment called MISSKEY_USE_HARD_SOURCE to use HardSourceWebpackPlugin.

@acid-chicken acid-chicken added 🛠️Dev Development of Misskey itself ✨Feature This adds/improves/enhances a feature labels Oct 31, 2019
@acid-chicken acid-chicken self-assigned this Oct 31, 2019
@syuilo syuilo merged commit e1cf090 into develop Oct 31, 2019
@syuilo
Copy link
Member

syuilo commented Oct 31, 2019

ありがとうございます👍
Webpack5ではパフォーマンスが改善されてそのうち不要になりそうな予感

@syuilo syuilo deleted the acid-chicken-patch-5 branch October 31, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo Awaiting requested review from syuilo

Assignees

@acid-chicken acid-chicken

Labels
🛠️Dev Development of Misskey itself ✨Feature This adds/improves/enhances a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why HardSourceWebpackPlugin is commented?
2 participants
@acid-chicken @syuilo