Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Badge Image to Push Notification #8012

Merged
merged 578 commits into from
Jun 19, 2022
Merged

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Nov 22, 2021

Resolve #7206

What

#7667 の続きで、Service Workerのプッシュ通知で🔔のかわりにバッジを表示するようにします。

Changes→tamaina/misskey@swn...tamaina:icons-2

@tamaina tamaina mentioned this pull request Apr 27, 2022
9 tasks
@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels May 27, 2022
@ThatOneCalculator
Copy link
Contributor

Is there anything preventing this from being reviewed/merged?

@tamaina
Copy link
Contributor Author

tamaina commented Jun 17, 2022

マージするぞ

Copy link
Member

@syuilo syuilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOSASOU

@rinsuki rinsuki self-requested a review June 17, 2022 07:47
Copy link
Contributor

@rinsuki rinsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

カスタム絵文字の二値化はちょっと微妙な気はするけど実際どんなもんなんだろ

packages/client/src/components/autocomplete.vue Outdated Show resolved Hide resolved
packages/backend/src/server/proxy/proxy-media.ts Outdated Show resolved Hide resolved
packages/sw/src/scripts/create-notification.ts Outdated Show resolved Hide resolved
@tamaina
Copy link
Contributor Author

tamaina commented Jun 17, 2022

カスタム絵文字の二値化はちょっと微妙

二値化やめました

@tamaina tamaina requested review from rinsuki and syuilo June 19, 2022 05:54
@tamaina
Copy link
Contributor Author

tamaina commented Jun 19, 2022

マージするか

@tamaina tamaina merged commit b70473e into misskey-dev:develop Jun 19, 2022
Jeder321 pushed a commit to Jeder321/misskey that referenced this pull request Jul 13, 2022
* fix

* nanka iroiro

* wip

* wip

* fix lint

* fix loginId

* fix

* refactor

* refactor

* remove follow action

* clean up

* Revert "remove follow action"

This reverts commit defbb41.

* Revert "clean up"

This reverts commit f94919c.

* remove fetch specification

* renoteの条件追加

* apiFetch => cli

* bypass fetch?

* fix

* refactor: use path alias

* temp: add submodule

* remove submodule

* enhane: unison-reloadに指定したパスに移動できるように

* null

* null

* feat: ログインするアカウントのIDをクエリ文字列で指定する機能

* null

* await?

* rename

* rename

* Update read.ts

* merge

* get-note-summary

* fix

* swパッケージに

* add missing packages

* fix getNoteSummary

* add webpack-cli

* ✌️

* remove plugins

* sw-inject分離したがテストしてない

* fix notification.vue

* remove a blank line

* disconnect intersection observer

* disconnect2

* fix notification.vue

* remove a blank line

* disconnect intersection observer

* disconnect2

* fix

* ✌️

* clean up config

* typesを戻した

* backend/src/web/index.ts

* notification-badges

* add scripts

* change create-notification.ts

* Update packages/client/src/components/notification.vue

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>

* disconnect

* oops

* Failed to load the script unexpectedly回避
sw.jsとlib.tsを分離してみた

* truncate notification

* Update packages/client/src/ui/_common_/common.vue

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

* clean up

* clean up

* refactor

* キャッシュ対策

* Truncate push notification message

* fix

* クライアントがあったらストリームに接続しているということなので通知しない判定の位置を修正

* components/drive-file-thumbnail.vue

* components/drive-select-dialog.vue

* components/drive-window.vue

* merge

* fix

* Service Workerのビルドにesbuildを使うようにする

* return createEmptyNotification()

* fix

* fix

* i18n.ts

* update

* ✌️

* remove ts-loader

* fix

* fix

* enhance: Service Workerを常に登録するように

* pollEnded

* pollEnded

* URLをsw.jsに戻す

* clean up

* fix lint

* changelog

* alpha-test

* also with twemoji

* add isMimeImage function

* catch

* Colour => Color

* char2file => char2filePath

* Update autocomplete.vue

* remove clone?

Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Workerのプッシュ通知用にFont Awesomeアイコンのpngを提供する機能をつくる
4 participants