fix: regular expressions in word mutes

[Johann150]

What

• Handle SyntaxExceptions from faulty RegExps in word mutes.
• Prevent such exceptions from occurring in the first place by
  • checking that regular expressions in word mutes have valid syntax in the frontend and
  • checking that regular expressions in hard word mutes have valid syntax in the backend (endpoint api/i/update).
• Clean up empty lines etc. when setting word mutes instead of when checking each note. This should improve perfomance.
• Correctly handle regular expressions containing spaces: Before they would be split at spaces like other lines, causing them not to be recognized.

Why

Handling exceptions fixes #8245.
Preventing such exceptions improves the user experience.

Additional info

The storage format of muted words will be changed to Array<string | string[]>, where an array element of type string represents a regular expression, and string[] represents a normal word mute.

Hard word mutes can be migrated, but soft word mutes may stop working correctly if they contain RegExps or empty lines. This can be fixed by going to soft word mute settings and saving once. This will update the structure to the new format.

To do

• Fix behaviour of frontend.
• Fix behaviour of backend
  • migration for hard word mutes.
• New i18n strings need to be added. English version below, Japanese version welcome. 🙏

regexpError: "Regular Expression error"
regexpErrorDescription: "Error in the regular expression on line {line} in your {tab} word mutes:"

[robflop]

Suggestions for japanese strings:

regexpError: "正規表現エラー"
regexErrorDescription: "{tab}ワードミュートの{line}列の正規表現にエラーが発生しました:"

Not completely sure what the {tab} bit refers to, so this might be wrong.

[Johann150]

Not completely sure what the {tab} bit refers to, so this might be wrong.

It will be either _wordMute.soft or _wordMute.hard, so they know which tab the line number is from.

[robflop]

Ah, thanks. In this case, the string should be suitable.

[syuilo]

LGTM

[mei23]

Approvedなら別にいいけど、マイグレーションって必須？
この辺の対応項目ってIssueで最初に議論するんじゃなかったのだわ？

[syuilo]

理想的には実装前にIssueで実装方針の認識が合わされてた方がベターだね

[syuilo]

🙏

[tamaina]

ソフトミュートを設定しているとバグる（が私はまだコードを呑み込めていない）

[tamaina]

check-word-muteのmatched内のreturn falseが問題やな

[syuilo]

ミュート設定しなおすと直ると思う

[tamaina]

ミュート設定しなおすと直ると思う

それはいただけない
ブラウザコンソールとか開かない限り設定前の値が出てこないし

[tamaina]

とりあえずreturn falseせずに後方互換性を確保したい

[tamaina]

いやなんか勘違いしてた

[tamaina]

(return falseのせいではなかった