-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regular expressions in word mutes #8254
Conversation
a3a1a26
to
52e9ab5
Compare
Suggestions for japanese strings: regexpError: "正規表現エラー"
regexErrorDescription: "{tab}ワードミュートの{line}列の正規表現にエラーが発生しました:" Not completely sure what the |
It will be either |
Ah, thanks. In this case, the string should be suitable. |
3a20ff1
to
fcb245b
Compare
fcb245b
to
ba32c3d
Compare
Co-authored-by: rinsuki <428rinsuki+git@gmail.com>
ba32c3d
to
d78f5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Approvedなら別にいいけど、マイグレーションって必須? |
理想的には実装前にIssueで実装方針の認識が合わされてた方がベターだね |
This comment was marked as off-topic.
This comment was marked as off-topic.
🙏 |
check-word-muteのmatched内のreturn falseが問題やな |
ミュート設定しなおすと直ると思う |
それはいただけない |
とりあえずreturn falseせずに後方互換性を確保したい |
いやなんか勘違いしてた |
(return falseのせいではなかった |
What
SyntaxException
s from faultyRegExp
s in word mutes.api/i/update
).Why
Handling exceptions fixes #8245.
Preventing such exceptions improves the user experience.
Additional info
The storage format of muted words will be changed to
Array<string | string[]>
, where an array element of typestring
represents a regular expression, andstring[]
represents a normal word mute.Hard word mutes can be migrated, but soft word mutes may stop working correctly if they contain
RegExp
s or empty lines. This can be fixed by going to soft word mute settings and saving once. This will update the structure to the new format.To do