enhance(client): Sync widgets #8512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* classic.widgets.vueの機能をuniversal.widgets.vueに統合 * 左右のウィジェット編集状態を同期するように * 左右やカラム間でウィジェットを行き来できるように * MkWidgetsをCSS Module化
Codecov Report
@@ Coverage Diff @@
## develop #8512 +/- ##
========================================
Coverage 22.41% 22.41%
========================================
Files 704 704
Lines 66017 66017
Branches 2134 2134
========================================
Hits 14801 14801
Misses 51216 51216 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
🆙 |
syuilo
reviewed
Dec 26, 2022
| } | ||
|
|
||
| .edit { | ||
| &-header { |
There was a problem hiding this comment.
&hogeはCSS被害者救済法で禁止されているから、
みたいに&:global使えば良さそうThere was a problem hiding this comment.
&hogeはCSS被害者救済法で禁止されているから、
そんな法律知らなかった…
みたいに&:global使えば良さそう
パフォーマンス悪くなるらしいのでネストは使いたくない
syuilo
reviewed
Dec 26, 2022
については考え中だけどもそれ以外は良さそう |
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
|
👍 |
|
新しいデバイスからログインされるとウィジェットが初期状態に戻る気がする |
|
pizzaxのi/registry/get-allが終わるまでの間にuniversal.vueがmountされると発生する |
syuilo
added a commit
that referenced
this pull request
Jan 2, 2023
|
#9225 が適用されていると発見できなかったのか…？ |
This was referenced Jan 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #7724
What
クラシックUIの上部メニュー状態において、デフォルトUIやクラシックUI左側サイドメニューで追加されたウィジェットは、右側に配置されます。
Additional info (optional)
p1.a9z.devで動作中