refact(NA): remove set loop from upgrade assistant usage collector (e…

…lastic#63977) * refact(NA): use default telemetry obj in the set loop * chore(NA): fix typecheck * fix(NA): test run with lodash has * chore(NA): fix older lodash has * chore(NA): remove lodash has usage
mistic · Apr 22, 2020 · 0c0ac78 · 0c0ac78
1 parent f570c0d
commit 0c0ac78
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.test.ts b/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.test.ts
@@ -51,6 +51,7 @@ describe('Upgrade Assistant Usage Collector', () => {
                   'ui_reindex.open': 4,
                   'ui_reindex.start': 2,
                   'ui_reindex.stop': 1,
+                  'ui_reindex.not_defined': 1,
                 },
               };
             },

diff --git a/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts b/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts
@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { set } from 'lodash';
+import { get } from 'lodash';
 import {
   APICaller,
   ElasticsearchServiceSetup,
@@ -84,16 +84,19 @@ export async function fetchUpgradeAssistantMetrics(
       return defaultTelemetrySavedObject;
     }
 
-    const upgradeAssistantTelemetrySOAttrsKeys = Object.keys(
-      upgradeAssistantTelemetrySavedObjectAttrs
-    );
-    const telemetryObj = defaultTelemetrySavedObject;
-
-    upgradeAssistantTelemetrySOAttrsKeys.forEach((key: string) => {
-      set(telemetryObj, key, upgradeAssistantTelemetrySavedObjectAttrs[key]);
-    });
-
-    return telemetryObj as UpgradeAssistantTelemetrySavedObject;
+    return {
+      ui_open: {
+        overview: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_open.overview', 0),
+        cluster: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_open.cluster', 0),
+        indices: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_open.indices', 0),
+      },
+      ui_reindex: {
+        close: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.close', 0),
+        open: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.open', 0),
+        start: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.start', 0),
+        stop: get(upgradeAssistantTelemetrySavedObjectAttrs, 'ui_reindex.stop', 0),
+      },
+    } as UpgradeAssistantTelemetrySavedObject;
   };
 
   return {