refact(NA): remove set loop from upgrade assistant usage collector #63977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
added
the
release_note:skip
mistic
changed the title
legrego
reviewed
Apr 20, 2020
x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts
Outdated
Show resolved
Hide resolved
jloleysens
requested changes
Apr 21, 2020
There was a problem hiding this comment.
@mistic Thanks for adding this logic, would you mind describing in the PR what issue it was causing?
Also, I really would prefer to not use a dependency for this functionality, especially because there is native functionality Object.prototype.hasOwnProperty which does exactly what we want here. Use of lodash in general should be scaled back where possible.
mistic
changed the title
mistic
changed the title
mistic
changed the title
…from-ua-collector
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Apr 22, 2020
jloleysens
approved these changes
Apr 22, 2020
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 22, 2020
…lastic#63977) * refact(NA): use default telemetry obj in the set loop * chore(NA): fix typecheck * fix(NA): test run with lodash has * chore(NA): fix older lodash has * chore(NA): remove lodash has usage
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 22, 2020
…lastic#63977) * refact(NA): use default telemetry obj in the set loop * chore(NA): fix typecheck * fix(NA): test run with lodash has * chore(NA): fix older lodash has * chore(NA): remove lodash has usage
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 22, 2020
…lastic#63977) * refact(NA): use default telemetry obj in the set loop * chore(NA): fix typecheck * fix(NA): test run with lodash has * chore(NA): fix older lodash has * chore(NA): remove lodash has usage
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to remove set loop from the upgrade assistant usage collector.