Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradF update: After the most recent optimizations, the gradF update was
missing using the gradFnew calculated in the line search. From what I
can tell, this fix created no appreciable difference, but values are now
aligned with the MATLAB implementation.
d steps: changed the update strategy for d steps from using the min
(which meant that no elements of the u vector would need to be projected
back onto the pos orthant) to using the mean step (which means half of
the elements will have to be projected onto the pos orthant). This seems
to have produced a significant (2-4x) speedup on the bunny benchmark,
with no change on accuracy -- see report below.
recale_u0
: new parameter added to turn on / off the initial power method step to rescale u0. This does not seem to make an appreciable difference on bunny benchmark.this version
previous version