Migrate to Python 3 #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achernya
requested changes
Mar 30, 2023
| @@ -27,6 +27,8 @@ working directory is the root of the PyMoira source tree. | |||
| Alternatively, PyMoira has been packaged for Debian and Ubuntu. To | |||
| build the Debian package of the latest release, run:: | |||
|
|
|||
| _(NOTE: deb generation is untested)_ | |||
moira.py
Outdated
| """ | ||
| if isinstance(s, str): | ||
| return s.encode() | ||
| else: |
There was a problem hiding this comment.
Remove the else and unindent the return s since you early-return on line 30
gabrc52
commented
Aug 9, 2023
| @@ -23,6 +23,15 @@ | |||
| _et_cache = {} | |||
|
|
|||
|
|
|||
| def _to_bytes(s): | |||
There was a problem hiding this comment.
I am not completely sure how necessary this function is, but doing .encode() instead of _to_bytes everywhere I used _to_bytes results in messages like AttributeError: 'bytes' object has no attribute 'encode'. Did you mean: 'decode'?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also migrates from the older Pyrex to the newer Cython. Also note that I have not touched the
debianbranch or tested.debgeneration, so it may need some tweaking.