Prevent AIA files from being uploaded to projects as media assets

[marksherman]

It is possible for beginners who are trying to load a template AIA source file to upload them into an existing project as media assets. Beginners may be susceptible to this mistake if they had recently learned how to upload media assets, which is commonly a 1st or 2nd session event.

This mistake was observed during a teacher training.

I propose a feature that checks media uploads. If the user attempts to upload the AIA, refuse, and guide the user towards a web page describing how to use AIA files.

[halatmit]

NIce point. People also upload PDFs and DOC files. We ought to trap for
these. Any interest in writing the code for this?

== Hal Abelson
hal@mit.edu
Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty

On Mon, Dec 8, 2014 at 5:28 PM, Mark Sherman notifications@github.com
wrote:

It is possible for beginners who are trying to load a template AIA source
file to upload them into an existing project as media assets. Beginners may
be susceptible to this mistake if they had recently learned how to upload
media assets, which is commonly a 1st or 2nd session event.

This mistake was observed during a teacher training.

I propose a feature that checks media uploads. If the user attempts to
upload the AIA, refuse, and guide the user towards a web page describing
how to use AIA files.

—
Reply to this email directly or view it on GitHub
#173.

[jisqyv]

It actually might be useful to upload a PDF in some circumstances. When I found DOC and PDF files in the system, it was usually the result of someone unziping a project file into a directory with other stuff and then re-zipping it up and the other stuff gets included :-)

-Jeff

[jisqyv]

P.S. I can easily put in a check for files ending in ".aia" and generate an appropriate error.

[marksherman]

If Jeff makes the error, I'll write the explanation page to go with it.
On Mon, Dec 8, 2014 at 10:20 PM Jeffrey Schiller notifications@github.com
wrote:

P.S. I can easily put in a check for files ending in ".aia" and generate
an appropriate error.

—
Reply to this email directly or view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mit-2Dcml_appinventor-2Dsources_issues_173-23issuecomment-2D66229087&d=AAMCaQ&c=TqceLeU8_c9CVUat-eLTFu19-lyGiWSvB_skZXlxt8Q&r=k-tN9RiDS5X8a15wxR_FMzWjUtK1yw-seWE6tKapqes&m=xdDXwuCszhbvBj_-rlKeVt0D0-eZmbIVejWqXJS0qYg&s=R1A6bEKFXP1tb04FOAlFLWVZjBZK8Nj1pHe1JLuw9xs&e=
.

[halatmit]

@jisqyv
I can put this check in, but I don't know where to put it. Somewhere in FileUploadWizard??

[josmas]

@jisqyv have just removed you from this one; marking as help needed for easy fixes to get started with the sources.

[varunm22]

Hi, my name is Varun! I'm a new UROP student with the App Inventor team.
@bxie assigned this to me as a starter project
I'll prevent AIA files from being uploaded as media assets.

[wadleo]

I have added an appropriate condition to check if the file being uploaded is an aia file in the FileUploadWizard class. I have also added an appropriate error message in OdeMessages class and will soon sent a pull request, thanks.

[marksherman]

I'll check it out this week, @wadleo (though I have no pull power, it seems right that I give it a test!)

[wadleo]

thanks @marksherman, waiting for your reply.

[bxie]

@wadleo : this may be redundant work.
@varunm22 has been working on this over the past month and his work is almost ready to be merged (currently working on some UI fixes).

@varunm22 please confirm

[wadleo]

Hello @bxie,
sorry i didn't realise he is still working on this looking at the dates above and please can you provide a link to his work, thanks for the info.

[varunm22]

Hi @wadleo my fixes are on the bytesize branch of my fork at https://github.com/varunm22/appinventor-sources/tree/bytesize. In addition to adding the .aia fix, I've replaced the window.alerts that show up during file upload errors with dialog boxes for greater consistency.

[wadleo]

Hi @varunm22, thanks for the feedback.

[varunm22]

Hi @wadleo, sorry for the confusion, and please let me know if you have any more questions!

[ewpatton]

Closed by #747