Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: In asset upload, coerce bad characters in file names into good ones #184

Closed
marksherman opened this issue Dec 19, 2014 · 4 comments

Comments

@marksherman
Copy link
Member

Instead of simply failing to upload, rename the file automatically during upload to become valid.
For example: changing dashes and spaces to underscores.

Solution may be related to #173
@jisqyv

@halatmit
Copy link
Contributor

halatmit commented Jul 4, 2015

@marksherman
I suggest that we not do this. It seems a little dangerous that you upload a file and then don't know exactly what name that file might be written under. I know we could provide a mechanism to handle this, but I'll feeling conservative, and also feeling that we have too may open issues. If you want to take ti on, go ahead. But otherwise, let's just close it, OK?

@marksherman
Copy link
Member Author

Ok with me. It was a common hitch-up point we saw in some middle schools,
but, yes, it does fail safely.

On Sat, Jul 4, 2015, 1:13 PM hal notifications@github.com wrote:

@marksherman
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_marksherman&d=AwMCaQ&c=TqceLeU8_c9CVUat-eLTFu19-lyGiWSvB_skZXlxt8Q&r=k-tN9RiDS5X8a15wxR_FMzWjUtK1yw-seWE6tKapqes&m=O4RTCwos_nY6EiOn6LSHSfg-mJ3fE2ZWO58EfxqDaGk&s=f7ozEXfRCSt1NSg7mfYJ1tfnSeohQOqtweN7-xZ7FWI&e=
I suggest that we not do this. It seems a little dangerous that you upload
a file and then don't know exactly what name that file might be written
under. I know we could provide a mechanism to handle this, but I'll feeling
conservative, and also feeling that we have too may open issues. If you
want to take ti on, go ahead. But otherwise, let's just close it, OK?


Reply to this email directly or view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mit-2Dcml_appinventor-2Dsources_issues_184-23issuecomment-2D118535200&d=AwMCaQ&c=TqceLeU8_c9CVUat-eLTFu19-lyGiWSvB_skZXlxt8Q&r=k-tN9RiDS5X8a15wxR_FMzWjUtK1yw-seWE6tKapqes&m=O4RTCwos_nY6EiOn6LSHSfg-mJ3fE2ZWO58EfxqDaGk&s=Couln9yzCt6A2HwcyvfWsGdfXLp-4oaFsVRGOMM2G48&e=
.

@halatmit
Copy link
Contributor

halatmit commented Jul 4, 2015

Closing the issue

@halatmit halatmit closed this as completed Jul 4, 2015
@halatmit
Copy link
Contributor

halatmit commented Jul 4, 2015

Thanks. I'll close this.

== Hal Abelson
hal@mit.edu
Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty

On Sat, Jul 4, 2015 at 2:30 PM, Mark Sherman notifications@github.com
wrote:

Ok with me. It was a common hitch-up point we saw in some middle schools,
but, yes, it does fail safely.

On Sat, Jul 4, 2015, 1:13 PM hal notifications@github.com wrote:

@marksherman
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_marksherman&d=AwMCaQ&c=TqceLeU8_c9CVUat-eLTFu19-lyGiWSvB_skZXlxt8Q&r=k-tN9RiDS5X8a15wxR_FMzWjUtK1yw-seWE6tKapqes&m=O4RTCwos_nY6EiOn6LSHSfg-mJ3fE2ZWO58EfxqDaGk&s=f7ozEXfRCSt1NSg7mfYJ1tfnSeohQOqtweN7-xZ7FWI&e=

I suggest that we not do this. It seems a little dangerous that you
upload
a file and then don't know exactly what name that file might be written
under. I know we could provide a mechanism to handle this, but I'll
feeling
conservative, and also feeling that we have too may open issues. If you
want to take ti on, go ahead. But otherwise, let's just close it, OK?


Reply to this email directly or view it on GitHub
<
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mit-2Dcml_appinventor-2Dsources_issues_184-23issuecomment-2D118535200&d=AwMCaQ&c=TqceLeU8_c9CVUat-eLTFu19-lyGiWSvB_skZXlxt8Q&r=k-tN9RiDS5X8a15wxR_FMzWjUtK1yw-seWE6tKapqes&m=O4RTCwos_nY6EiOn6LSHSfg-mJ3fE2ZWO58EfxqDaGk&s=Couln9yzCt6A2HwcyvfWsGdfXLp-4oaFsVRGOMM2G48&e=

.


Reply to this email directly or view it on GitHub
#184 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants