Fix project loading with bad text-number connections #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug has come up a number of times on the forum. Here's the most recent example: https://community.appinventor.mit.edu/t/the-blocks-area-did-not-load-properly-changes-to-the-blocks-for-screen-5690035441500160-scrhoy-will-not-be-saved/7729?u=ewpatton |
Change-Id: I78c1666fd34346e46e68e112d02603e4de197fa5
ewpatton
force-pushed
the
hotfix/text-number-loading
branch
from
b6dda5d
to
7e6aff6
Compare
Change-Id: I52e646cbfab94cf4a317c9149146bd01fd0da49a
|
I like the tests :D |
jisqyv
approved these changes
May 2, 2020
ellelili2025
reviewed
May 4, 2020
| @@ -471,13 +471,15 @@ Blockly.WorkspaceSvg.prototype.loadBlocksFile = function(formJson, blocksContent | |||
| if (blocksContent.length != 0) { | |||
| try { | |||
| Blockly.Events.disable(); | |||
| this.isLoading = true; | |||
There was a problem hiding this comment.
Can you help to explain why this is needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213
Change-Id: I78c1666fd34346e46e68e112d02603e4de197fa5