Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for malformed signature and schnorrKey fields in verifyTransaction #46

Merged
merged 2 commits into from
Jul 7, 2018

Conversation

metalicjames
Copy link
Member

We don't catch Json::Exceptions in verifyTransaction so we must check if the signature input data field or schnorrKey output data field are not strings otherwise one can cause a node to crash. Added a unit test for this eventuality to catch regressions.

We don't catch Json::Exceptions in verifyTransaction so we must check if those fields are not strings otherwise you can cause a crash
@metalicjames metalicjames merged commit 16b2d76 into mit-dci:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant