Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Updates + Bug Fixes (Updated Version of #206) #236

Merged
merged 49 commits into from
Feb 21, 2024

Conversation

GenericP3rson
Copy link
Collaborator

After some hard reset issues, this is the revived PR of #206

GenericP3rson and others added 30 commits October 15, 2023 19:01
Merging Dev to Get Latest Updates (Esp. with Isometry)
Copy link
Collaborator

@Hanrui-Wang Hanrui-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@Hanrui-Wang Hanrui-Wang merged commit 497320c into mit-han-lab:dev Feb 21, 2024
4 of 7 checks passed
@Hanrui-Wang
Copy link
Collaborator

Thank you GenericP3rson for the important contributions! especially the testing of examples, i will merge it now. Please have a look at the testing of python 3.12 seems to have some issues

@GenericP3rson
Copy link
Collaborator Author

I opened an issue on it, it's something with a library we depend on depends on a library that isn't supported in 3.12. I'll definitely deep dive to get that working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants