Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict validation against Hydra's supported primitives #163

Merged
merged 38 commits into from Nov 26, 2021
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
9c99844
add initial framework for zen value conversion
rsokl Nov 13, 2021
117a495
Validate that all configured values satisfy Hydra serializability
rsokl Nov 16, 2021
a77e6b5
bugfix: ref to wrong variable
rsokl Nov 16, 2021
80ce1e8
cleanup test boilerplate
rsokl Nov 16, 2021
69fcc32
fix bug
rsokl Nov 16, 2021
7b5e777
add support for set; normalize builds-error
rsokl Nov 16, 2021
da8577a
add validation/conversion to contents of supported collections: tuple…
rsokl Nov 16, 2021
ce775ea
Validation now requires exact match against types -- subclasses no lo…
rsokl Nov 16, 2021
3a1936b
add tests for zen-supported primitives
rsokl Nov 16, 2021
3c51fb7
add support for complex values
rsokl Nov 16, 2021
9063dac
add support for Path objects
rsokl Nov 16, 2021
4d76cce
remove extra complex implementation
rsokl Nov 17, 2021
d260196
update type-annotations to reflect supported primitives
rsokl Nov 17, 2021
0d1ab7d
add frozenset support
rsokl Nov 17, 2021
cae567f
improve test
rsokl Nov 17, 2021
8c147ce
relax health checks
rsokl Nov 17, 2021
35f4881
eliminate redundant dict copy
rsokl Nov 17, 2021
46a3216
ensure zen-converted values are supported by Hydra
rsokl Nov 22, 2021
2459b4c
Add support for enum members
rsokl Nov 22, 2021
245f0cd
add explicit tests for supported primitives
rsokl Nov 22, 2021
986dd5c
add support for additional primitives
rsokl Nov 23, 2021
d8a7fe3
remove straggler line
rsokl Nov 23, 2021
21a14fa
clean up import
rsokl Nov 23, 2021
358c9b2
make test compatible with python 3.6
rsokl Nov 23, 2021
62496a8
remove unused imports
rsokl Nov 23, 2021
c9d5aea
dataclasses are not permitted for dict-key nodes
rsokl Nov 23, 2021
6303a77
inline just-if-needed; dont permit structured configs as keys
rsokl Nov 25, 2021
208fa4e
add support for omegaconf containers
rsokl Nov 25, 2021
935da18
ensure omegaconf containers not permitted as dict keys
rsokl Nov 25, 2021
d5d73aa
remove unused function
rsokl Nov 25, 2021
c383825
add annotation support for range; remove redundant annotations
rsokl Nov 26, 2021
8a8ad2d
remove future import
rsokl Nov 26, 2021
52a95eb
remove unused import
rsokl Nov 26, 2021
423e5fd
add docs for features
rsokl Nov 26, 2021
b3622dc
wrap long line
rsokl Nov 26, 2021
7481afb
test that meta fields are validated too
rsokl Nov 26, 2021
bc83d42
remove commented print
rsokl Nov 26, 2021
2a20bb8
fix bad test
rsokl Nov 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/hydra_zen/errors.py
Expand Up @@ -14,3 +14,7 @@ class HydraZenDeprecationWarning(HydraZenException, FutureWarning):
This is a subclass of FutureWarning, rather than DeprecationWarning, so
that the warnings that it emits are not filtered by default.
"""


class HydraZenUnsupportedPrimitiveError(HydraZenException, ValueError):
pass