Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable _partial_ for Hydra > 1.1.1 #230

Merged
merged 6 commits into from Feb 23, 2022
Merged

Enable _partial_ for Hydra > 1.1.1 #230

merged 6 commits into from Feb 23, 2022

Conversation

rsokl
Copy link
Contributor

@rsokl rsokl commented Feb 23, 2022

This PR enables compatibility with Hydra's new support for _partial_ in its instantiate API. See #186 for the PR that added support for this. For Hydra > 1.1.1, "partial'd" configs will no longer need to leverage zen_processing (assuming no other zen-features are utilized):

Before:

>>> from hydra_zen import builds, to_yaml
>>> Conf = builds(int, zen_partial=True)
>>> print(to_yaml(Conf))
_target_: hydra_zen.funcs.zen_processing
_zen_target: builtins.int
_zen_partial: true

After (assuming hydra-core>1.1.1 is installed):

>>> Conf = builds(int, zen_partial=True)
>>> print(to_yaml(Conf))
_target_: builtins.int
_partial_: true

This PR also adds CI tests against 1.1.2dev, so that we test against both 1.1.2dev and 1.2.0dev in our suite.

@rsokl rsokl added the enhancement New feature or request label Feb 23, 2022
@rsokl rsokl merged commit d250c59 into main Feb 23, 2022
@rsokl rsokl deleted the hydra-1p2p0 branch February 23, 2022 22:34
@rsokl rsokl added this to the hydra-zen 0.6.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant