Revise implementation of PartialBuilds
#235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #230 this PR changes implementation of
PartialBuilds
to reflect thatbuilds(<target>, zen_partial=True)
can implement either the_partial_
protocol or the_zen_partial
protocol. Accordingly,hydra_zen.typing
now exposes two protocols:HydraPartialBuilds
andZenPartialBuilds
, andPartialBuilds
is their union.Any libraries that leverage
PartialBuilds
in their type annotations will likely not see any breaking changes in their static analysis. However, code that usedPartialBuilds
to perform runtime checking will need to update their code:e.g., from
to
In the future (certainly not until after Hydra 1.1.2 is released), the annotations of
builds
may be revised to more precisely reflect whenHydraPartialBuilds
vsZenPartialBuilds
is returned.