Added env()->ExceptionClear() everywhere before throwing NameResolutionException
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpavlik
reviewed
May 17, 2024
| @@ -733,8 +743,10 @@ namespace jni | |||
| if (sig != nullptr) | |||
| return getStaticMethod(std::string(nameAndSignature, sig - nameAndSignature).c_str(), sig); | |||
|
|
|||
| if (id == nullptr) | |||
| if (id == nullptr) { | |||
| env()->ExceptionClear(); | |||
There was a problem hiding this comment.
Is it ever possible to get in here when there is no env set yet?
| @@ -709,8 +715,10 @@ namespace jni | |||
| if (sig != nullptr) | |||
| return getMethod(std::string(nameAndSignature, sig - nameAndSignature).c_str(), sig); | |||
|
|
|||
| if (id == nullptr) | |||
| if (id == nullptr) { | |||
| env()->ExceptionClear(); | |||
There was a problem hiding this comment.
Same here - is it possible to get in without setting env?
|
I wonder if there is a way to add a test for this. I guess we would have to throw a JNI exception that wouldn't be handled by jnipp? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncleared exceptions cause SegFault on Android.
Android developer docs:You must not call most JNI functions while an exception is pending.