This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
+1 The fix even works for me. Could you please tell us by when this PR will get merged to master? |
Hi Team, May I know if there is any plan to merge this PR? Thanks in advance. |
Hi @mitchellh Could you please tell me if there are any plans to merge this PR? |
@andrewhsu and @kbhute-ibm I'll take a look at this. It would be great to support more platforms. |
@mattfarina
Could you please take a look? |
I think this PR becomes obsolete if #96 is merged? |
Covered by #96 |
Can be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.7 adds support for s390x. This PR changes
gox
to be able to compile on it.Tests pass:
Example compile using
gox
specifyings390x