Fix empty slice not allocated #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitchellh do you have time for a look? I really need to know the expected behavior(whether the original issue is valid or not) and I need to fix other softwares which use mapstructure. |
|
Is there an update on this? |
This was referenced Feb 18, 2020
|
Thank you! |
sagikazarmark
added a commit
to spf13/viper
that referenced
this pull request
Sep 30, 2020
Mapstructure so far returned nil for empty string slices. In a recent version this bug has been fixed: mitchellh/mapstructure#155 Incidentally, this was a bug in Viper too: GetStringSlice and Unmarshal returned with different values. Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
added a commit
to spf13/viper
that referenced
this pull request
Sep 30, 2020
Mapstructure so far returned nil for empty string slices. In a recent version this bug has been fixed: mitchellh/mapstructure#155 Incidentally, this was a bug in Viper too: GetStringSlice and Unmarshal returned with different values. Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
added a commit
to spf13/viper
that referenced
this pull request
Sep 30, 2020
Mapstructure so far returned nil for empty string slices. In a recent version this bug has been fixed: mitchellh/mapstructure#155 Incidentally, this was a bug in Viper too: GetStringSlice and Unmarshal returned with different values. Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
brainexe
pushed a commit
to brainexe/viper
that referenced
this pull request
Nov 12, 2020
Mapstructure so far returned nil for empty string slices. In a recent version this bug has been fixed: mitchellh/mapstructure#155 Incidentally, this was a bug in Viper too: GetStringSlice and Unmarshal returned with different values. Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a testcase, which will fail without patch.
Closes: #146