Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper bound for hspec #8

Merged
merged 1 commit into from
Aug 22, 2015

Conversation

markus1189
Copy link
Contributor

hspec 2.2.0 changes the Fail constructor to take one argument more (Maybe Location):

Before:

-- | The result of running an example
data Result = Success | Pending (Maybe String) | Fail String
  deriving (Eq, Show, Read, Typeable)

After:

-- | The result of running an example
data Result = Success | Pending (Maybe String) | Fail (Maybe Location) String
  deriving (Eq, Show, Read, Typeable)

This leads to build failures like this:

    Test/Tasty/Hspec.hs:53:27:
        Constructor ‘H.Fail’ should have 2 arguments, but has been given 1
        In the pattern: H.Fail str
        In an equation for ‘hspecResultToTastyResult’:
            hspecResultToTastyResult (H.Fail str) = T.testFailed str

For now, I changed the upper bound for hspec (, hspec >=2 && <2.2) and bumped the version to 1.1.1. I guess it's worth a thought if we also need a bound on hspec-core but for now this seems to be sufficient as-is.

Best,
Markus

hspec 2.2.0 changes the 'Fail' constructor to take one argument more
mitchellwrosen added a commit that referenced this pull request Aug 22, 2015
@mitchellwrosen mitchellwrosen merged commit 8dd3769 into mitchellwrosen:master Aug 22, 2015
@mitchellwrosen
Copy link
Owner

Thanks Markus.

@mitchellwrosen
Copy link
Owner

1.1.1 uploaded to hackage

@markus1189
Copy link
Contributor Author

Awesome :)
On Aug 22, 2015 8:17 PM, "Mitchell Rosen" notifications@github.com wrote:

1.1.1 uploaded to hackage


Reply to this email directly or view it on GitHub
#8 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants