Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for filters #43

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Plugin for filters #43

merged 2 commits into from
Jan 5, 2018

Conversation

rajaramsrinivas
Copy link

The current version allows for plugins to be separate methods in analyze_modules.py going by the name analyze_. This attribute should be added in two new locations:

  1. In models.py for db field name
  2. in tasks in list ANALYSIS_TYPE of scripts/tasks.py

Since api/feed.py already queries for all attributes, by default, only UI will need to be modified from here.

Please review and approve pull request if you deem the changes fit.

@rahulbot
Copy link
Collaborator

rahulbot commented Jan 5, 2018

This seems like a good first step, but doesn't really do a plugin pattern. You're using a whitelist and then a naming convention to discover analysis methods. That's better than what we've got now, but from an architecture point of view I think a more plug-in oriented approach would involve some mechanism for registering analytic plug-ins with gobo from individual modules. I merge this, because it is an improvement, but lets discuss a more robust solution on #32.

@rahulbot rahulbot merged commit 18ea227 into master Jan 5, 2018
@rahulbot rahulbot deleted the plugin_for_filters branch January 30, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants