Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Replace from file to Replacement Editor #1458

Closed
dufferzafar opened this issue Aug 1, 2016 · 3 comments
Closed

Add Replace from file to Replacement Editor #1458

dufferzafar opened this issue Aug 1, 2016 · 3 comments

Comments

@dufferzafar
Copy link
Contributor

We have a replacement editor (press o then R in mitmproxy) that allows us to add replacement patterns for flows.

There's also a --replace-from-file cmdline option that gets the replacement text from a local file.

But this functionality can't be used from the replacement editor itself.


A user tried to enter the path to file in the Replacement text field: https://discourse.mitmproxy.org/t/emulate-charles-proxys-map-local/116

@arjunkaruvally
Copy link
Contributor

Is anyone currently working on this issue ? If no, may I work on this ?

@dufferzafar
Copy link
Contributor Author

@arjun23496 I don't think anyone is working so feel free to take it up, but before you start I think it'll be nice if you discuss your ideas with the dev team over at Slack.

@cortesi
Copy link
Member

cortesi commented Mar 14, 2017

Fixed by #2120

@cortesi cortesi closed this as completed Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants