docs: stub out new script documentation #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortesi
changed the title
cortesi
force-pushed
the
scriptdocs
branch
3 times, most recently
from
bbcb00f
to
0971e05
Compare
- Hide links to internal code listings, and link to github instead - Improve formatting of code/example captions - Fix outdated documentation of command-line options - Complete documentation of all events + improved formatting - tcp_open -> tcp_start, tcp_close -> tcp_end to reduce confusion
- We don't need a deprecation warning here - Bring imports inline with policy
Add the terminal logger before any other addons, so we see script errors on startup.
This is so we can see the effects of script rewriting using -dd.
We need scripts to run _before_ filestreamer, so we can't just add them to the end of the chain. This patch also fixes an issue that could cause scripts to be initialised un-necessarily if only the order of scripts in options changed.
Current coverage is 80.84% (diff: 93.75%)@@ master #1602 diff @@
==========================================
Files 143 143
Lines 12342 12351 +9
Methods 0 0
Messages 0 0
Branches 2016 2018 +2
==========================================
+ Hits 9973 9985 +12
+ Misses 2087 2085 -2
+ Partials 282 281 -1
|
cortesi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change TCP-related event names for clarity