first draft of read har. #6190
Merged
first draft of read har. #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
Jun 23, 2023
examples/contrib/readhar.py
Outdated
Comment on lines
130
to
131
| self.running() | ||
| self._read_har_task |
There was a problem hiding this comment.
This here can be greatly simplified I think. You can just do this here instead and avoid the functions above:
Suggested change
| self.running() | |
| self._read_har_task | |
| async def load_flows() -> None: | |
| for flow in flows: | |
| await ctx.master.load_flow(flow) | |
| asyncio.create_task(load_flows()) |
The main underlying problem here is that commands cannot be async yet, otherwise we could just call await ctx.master.load_flow(flow) directly.
|
Thanks! Your feedback was super helpful! Here is the updated version of my code. |
mhils
reviewed
Jun 27, 2023
examples/contrib/readhar.py
Outdated
| ) | ||
|
|
||
| # 375:3 is default mitmproxy server_conn when making a new flow. | ||
| server_conn = connection.Server(address=("375", 3)) |
There was a problem hiding this comment.
I don't comment and code here. Can you explain? :)
mhils
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Looks good! Please make sure that CI is passing (https://github.com/mitmproxy/mitmproxy/actions/runs/5405361567/jobs/9820804825), and then this is good to go! 😃
…into import-har
…into import-har
auto-merge was automatically disabled
June 30, 2023 01:03
Head branch was pushed to by a user without write access
lasting-yang
pushed a commit
to lasting-yang/mitmproxy
that referenced
this pull request
Aug 2, 2023
* first draft of read har. * [autofix.ci] apply automated fixes * Fixed using max's suggestions * [autofix.ci] apply automated fixes * updated to snake_case * [autofix.ci] apply automated fixes * Made max's changes. * [autofix.ci] apply automated fixes * gets server address from har file now * [autofix.ci] apply automated fixes * added support for if serverIPAdress wasnt found * [autofix.ci] apply automated fixes * editted docstring and changed peername and sockname values * fix nits * removed unused variable, should pass tox --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Maximilian Hils <git@maximilianhils.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added readhar to examples/contrib. Reads har files into mitmproxy.