This repository has been archived by the owner on Jun 1, 2018. It is now read-only.
Refactor HTTP Request Model #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this looks good to me. I don't love the name "data" for the inner attribute, but I also don't have any more explanatory suggestions. :) |
|
Refactored the Response class as well - we're now at 100% branch coverage for netlib.http, ready for review 😃 |
This was referenced Sep 26, 2015
| """ | ||
| HTTP request method, e.g. "GET". | ||
| """ | ||
| return _native(self.data.method) |
There was a problem hiding this comment.
how about also applying .upper() here? It would cleanup the code in a few other places, and if somebody really needs the raw method, it is still there.
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #99 and improves our Python 3 unicode story. We split the request class into RequestData, which works quite similar to
.fieldsfor Headers and Request, which provides convenientstraccess.@propertyfor all the attributes is a bit verbose, but it makes it pretty clear how things work. Also, there are proper docs for this on the mitmproxy/http-models branch. Last but not least, we use.contentas a default instead of.bodyagain, because that's what requests does.@cortesi, is this what you had in mind?
TODO: