-
-
Notifications
You must be signed in to change notification settings - Fork 68
Conversation
run the following command: $ autopep8 -i -r -a -a .
run the following command: $ autoflake -r -i --remove-all-unused-imports --remove-unused-variables .
cf3388a
to
a11f2a6
Compare
netlib.egg-info/ | ||
pathod/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be neccessary if you install mitmproxy using the instructions in https://github.com/mitmproxy/mitmproxy#hacking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is - somehow Travis creates this directory - and then the git-status check fails.
See https://travis-ci.org/mitmproxy/netlib/jobs/64226073#L199
Maybe it would be safer to remove the new Travis checks? What do you think?
Lets merge this and see. There are a few things that autopep8 does that I don't like (blank lines before class comments, for example), which we can exempt using the --ignore flag. I also think we should extract the autoflake and autopep8 commands into a script that we can run, add to a commit hook, configure our editors to run, etc. that makes sure what we do is consistent with what Travis does. |
What are your opinions on https://github.com/google/yapf? Worth a shot? |
Hmm... looks interesting. Let me play with it. I would love to have something that you can trust to just apply a totally consistent style, a la gofmt. |
run the following command:
$ autopep8 -i -r -a -a .
$ autoflake -i -r --remove-all-unused-imports --remove-unused-variables .