Skip to content
This repository has been archived by the owner on Jun 1, 2018. It is now read-only.

Cleanup #60

Merged
merged 3 commits into from
May 28, 2015
Merged

Cleanup #60

merged 3 commits into from
May 28, 2015

Conversation

Kriechi
Copy link
Member

@Kriechi Kriechi commented May 27, 2015

  • cleanup code with autopep8
  • cleanup code with autoflake
  • add pep8 autoformat check to travis

run the following command:
$ autopep8 -i -r -a -a .
$ autoflake -i -r --remove-all-unused-imports --remove-unused-variables .

run the following command:
  $ autopep8 -i -r -a -a .
run the following command:
  $ autoflake -r -i --remove-all-unused-imports --remove-unused-variables .
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 99.37% when pulling 7be95b6 on Kriechi:cleanup into f7b75ba on mitmproxy:master.

@Kriechi Kriechi force-pushed the cleanup branch 2 times, most recently from cf3388a to a11f2a6 Compare May 27, 2015 11:02
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 99.37% when pulling a11f2a6 on Kriechi:cleanup into f7b75ba on mitmproxy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.21%) to 99.37% when pulling 8037830 on Kriechi:cleanup into f7b75ba on mitmproxy:master.

netlib.egg-info/
pathod/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be neccessary if you install mitmproxy using the instructions in https://github.com/mitmproxy/mitmproxy#hacking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is - somehow Travis creates this directory - and then the git-status check fails.
See https://travis-ci.org/mitmproxy/netlib/jobs/64226073#L199

Maybe it would be safer to remove the new Travis checks? What do you think?

@cortesi
Copy link
Member

cortesi commented May 28, 2015

Lets merge this and see. There are a few things that autopep8 does that I don't like (blank lines before class comments, for example), which we can exempt using the --ignore flag. I also think we should extract the autoflake and autopep8 commands into a script that we can run, add to a commit hook, configure our editors to run, etc. that makes sure what we do is consistent with what Travis does.

@mhils
Copy link
Member

mhils commented May 28, 2015

What are your opinions on https://github.com/google/yapf? Worth a shot?

@cortesi
Copy link
Member

cortesi commented May 28, 2015

Hmm... looks interesting. Let me play with it. I would love to have something that you can trust to just apply a totally consistent style, a la gofmt.

@cortesi cortesi merged commit 8037830 into mitmproxy:master May 28, 2015
@Kriechi Kriechi deleted the cleanup branch May 28, 2015 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants