Fixed JS console error with react-router history #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the tests rely on being able to provide a history object that isn't a browser history. Did you investigate the |
|
I did not, I'll take a look |
|
@noisecapella yeah, I have no idea how to get around that, haha we can just delete this if we're fine with living with the warning |
|
It would be nice to fix this eventually but it's not blocking anything right now |
alicewriteswrongs
force-pushed
the
ap/fix-js-error
branch
from
d460b45
to
b6ebda9
Compare
|
@noisecapella I just took another stab at this, was following along with the docs here: https://github.com/reactjs/react-router/blob/master/upgrade-guides/v2.0.0.md#navigating-inside-deeply-nested-components seems to be working ok! tests are passing too. |
|
That's great! 👍 |
React router throws up a console warning if you grab `history` out of `this.props`. Following the docs here: https://github.com/reactjs/react-router/blob/master/upgrade-guides/v2.0.0.md we're now adding a `router` object in `this.context` on the components where we need to be pushing something onto the history.
alicewriteswrongs
force-pushed
the
ap/fix-js-error
branch
from
4b69ddc
to
1819255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
none
What's this PR do?
React router throws up a console warning if you grab
historyout ofthis.propsinstead of importing the history provider (e.g.browserHistoryorhashHistory) and calling.pushon that.This just makes that change, so the warning doesn't show up!
Where should the reviewer start?
static/js/containers/App.jsandstatic/js/containers/TermsOfServicePage.jsHow should this be manually tested?
agreed_to_terms_of_service == False/dashboardAny background context you want to provide?
Screenshots (if appropriate)
original warning (can repro by following the 'manual testing' steps on master):