Fixed JS console error with react-router history #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
none
What's this PR do?
React router throws up a console warning if you grab
history
out ofthis.props
instead of importing the history provider (e.g.browserHistory
orhashHistory
) and calling.push
on that.This just makes that change, so the warning doesn't show up!
Where should the reviewer start?
static/js/containers/App.js
andstatic/js/containers/TermsOfServicePage.js
How should this be manually tested?
agreed_to_terms_of_service == False
/dashboard
Any background context you want to provide?
Screenshots (if appropriate)
original warning (can repro by following the 'manual testing' steps on master):