chore: remove course/course topic association (#2649)

* chore: remove course/coursetopic association

cms/models.py

@@ -1177,11 +1177,6 @@ def product(self):
         """Gets the product associated with this page"""
         return self.course
 
-    def save(self, clean=True, user=None, log_action=False, **kwargs):
-        """Override save to set the topics to Django course models backwards"""
-        self.course.topics.set(self.topics.all())
-        super().save(clean=clean, user=user, log_action=log_action, **kwargs)
-
 
 class CoursePage(CourseProductPage):
     """

courses/admin.py

@@ -52,10 +52,9 @@ class CourseAdmin(admin.ModelAdmin):
     """Admin for Course"""
 
     model = Course
-    search_fields = ["title", "topics__name", "readable_id"]
+    search_fields = ["title", "readable_id"]
     list_display = ("id", "title", "get_program", "position_in_program")
-    list_filter = ["live", "program", "topics"]
-    readonly_fields = ("topics",)
+    list_filter = ["live", "program"]
     formfield_overrides = {
         models.CharField: {"widget": TextInput(attrs={"size": "80"})}
     }

courses/migrations/0033_remove_course_coursetopic_association.py

@@ -0,0 +1,17 @@
+# Generated by Django 3.2.18 on 2023-05-17 11:48
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("courses", "0032_remove_external_marketing_url_field"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="course",
+            name="topics",
+        ),
+    ]

courses/models.py

@@ -405,7 +405,6 @@ class Course(TimestampedModel, PageProperties, ValidateOnSaveMixin):
         max_length=255, unique=True, validators=[validate_url_path_field]
     )
     live = models.BooleanField(default=False)
-    topics = models.ManyToManyField(CourseTopic, blank=True)
     is_external = models.BooleanField(default=False)
 
     @property

courses/views/v1/__init__.py

@@ -39,8 +39,10 @@ class ProgramViewSet(viewsets.ReadOnlyModelViewSet):
     )
     courses_prefetch = Prefetch(
         "courses",
-        Course.objects.select_related("coursepage").prefetch_related(
-            course_runs_prefetch, "topics"
+        Course.objects.select_related(
+            "coursepage", "externalcoursepage"
+        ).prefetch_related(
+            course_runs_prefetch, "coursepage__topics", "externalcoursepage__topics"
         ),
     )
 
@@ -70,7 +72,11 @@ def get_queryset(self):
         queryset = (
             Course.objects.filter(live=True)
             .select_related("coursepage", "externalcoursepage")
-            .prefetch_related("topics", self.course_runs_prefetch)
+            .prefetch_related(
+                "coursepage__topics",
+                "externalcoursepage__topics",
+                self.course_runs_prefetch,
+            )
             .filter(Q(coursepage__live=True) | Q(externalcoursepage__live=True))
         )
 

localdev/seed/api.py

@@ -350,10 +350,6 @@ def _deserialize_courseware_object(self, serializer_cls, data):
             **filter_for_model_fields(model_cls, data),
             **{seeded_field_name: seeded_value},
         }
-
-        topics = []
-        if model_cls == Course and "topics" in adjusted_data:
-            topics = adjusted_data.pop("topics")
         existing_qset = model_cls.objects.filter(**{seeded_field_name: seeded_value})
         if existing_qset.exists():
             existing_qset.update(**adjusted_data)
@@ -369,10 +365,6 @@ def _deserialize_courseware_object(self, serializer_cls, data):
                 return None
             courseware_obj = serialized.save()
             self.seed_result.add_created(courseware_obj)
-
-        topic_objs = self._get_topic_objects(topics)
-        if courseware_obj is not None and len(topic_objs) > 0:
-            courseware_obj.topics.set(topic_objs)
         return courseware_obj
 
     def _get_topic_objects(self, topics):

localdev/seed/api_test.py

@@ -91,7 +91,8 @@ def test_topics(seeded):
     for course_data in seeded.raw_data["courses"]:
         course = Course.objects.get(readable_id=course_data["readable_id"])
         topics = [
-            {"name": topic.name} for topic in CourseTopic.objects.filter(course=course)
+            {"name": topic.name}
+            for topic in CourseTopic.objects.filter(coursepage=course.page)
         ]
 
         def name_key(topic):