fix: invalid certificate uuid should raise 404 #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arslanashraf7
requested changes
May 24, 2024
cms/models_test.py
Outdated
Comment on lines
1795
to
1814
| def test_course_run_certificate_get(user_client): | ||
| """Test that course run certificate get is successful for a valid UUID and raises 404 for invalid UUID""" | ||
| certificate = CourseRunCertificateFactory.create() | ||
| resp = user_client.get(f"/certificate/{certificate.uuid}/") | ||
| assert resp.status_code == 200 | ||
|
|
||
| invalid_uuid = str(certificate.uuid)[0:-12] | ||
| resp = user_client.get(f"/certificate/{invalid_uuid}/") | ||
| assert resp.status_code == 404 | ||
|
|
||
|
|
||
| def test_program_certificate_get(user_client): | ||
| """Test that program certificate get is successful for a valid UUID and raises 404 for invalid UUID""" | ||
| certificate = ProgramCertificateFactory.create() | ||
| resp = user_client.get(f"/certificate/program/{certificate.uuid}/") | ||
| assert resp.status_code == 200 | ||
|
|
||
| invalid_uuid = str(certificate.uuid)[0:-12] | ||
| resp = user_client.get(f"/certificate/program/{invalid_uuid}/") | ||
| assert resp.status_code == 404 |
There was a problem hiding this comment.
nit: We can refactor this in this way:
- A test only to check the valid certificate for both course and program certificate
- A parametrized test to check invalid certificates for both course & program certificate
We should check on multiple invalid UUIDs. Ideally making these tests parameterized for invalid e.g.
- Short string
- Empty String
- String longer than the length of UUID
There was a problem hiding this comment.
There were no existing tests so I just tried to put in some basic ones quickly but sure, I will add some more as you suggested.
arslanashraf7
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes Sentry error
Description (What does it do?)
Using an invalid UUID to get a course run or program certificate results in a 500 server error. It should return 404.
Steps to reproduce:
/certificate/f5ab714b-a7ee-498f-bbec-/How can this be tested?
/certificate/<uuid>/and the program certificate at/certificate/program/<uuid>/. You should see the valid certificates.f5ab714b-a7ee-498f-bbec-. You should see a 404 page.