ahmed-belal/mitxPro 310 - Convert Sections to Generic #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-arbisoft
force-pushed
the
ahmedbelal/310-convert-sections-generic
branch
from
ee40df5
to
ca763ca
Compare
asadiqbal08
changed the title
ahmed-arbisoft
force-pushed
the
ahmedbelal/310-convert-sections-generic
branch
from
ca763ca
to
c202f16
Compare
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
========================================
- Coverage 94.12% 94% -0.13%
========================================
Files 160 160
Lines 5400 5442 +42
Branches 312 314 +2
========================================
+ Hits 5083 5116 +33
- Misses 261 269 +8
- Partials 56 57 +1
Continue to review full report at Codecov.
|
This was referenced May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
#310
What's this PR do?
Converts
ForTeamsPage,LearningTechniquesPage,CoursesInProgramPageandUserTestimonialPageto generic data driven structure such that these subpages may be included anywhere else in the website, e.g. as a child of the Home Page and still work.How should this be manually tested?
(Required)
Where should the reviewer start?
(Optional)
Any background context you want to provide?
The home page design uses some of the sections already developed for the
Course Page. However, these sections were tightly coupled with the Course and CoursePage object and also were named as such. This PR Removes that tight coupling and makes things more configurable from the wagtail cms admin.