Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Header Bundle back to Original Location #330

Merged
merged 1 commit into from
May 21, 2019

Conversation

ahmed-arbisoft
Copy link
Contributor

@ahmed-arbisoft ahmed-arbisoft commented May 21, 2019

Pre-Flight checklist

  • Testing
    • Changes have been manually tested

What are the relevant tickets?

#329

What's this PR do?

Removes bug introduced by #311

How should this be manually tested?

Go to any React rendered page, the header should appear only once, not duplicated.

Copy link
Contributor

@gsidebo gsidebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files         168      168           
  Lines        5695     5695           
  Branches      330      330           
=======================================
  Hits         5366     5366           
  Misses        270      270           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117423b...2a20b69. Read the comment docs.

@ahmed-arbisoft ahmed-arbisoft merged commit 6f051c5 into master May 21, 2019
@ahmed-arbisoft ahmed-arbisoft deleted the ahmedbelal/329-move-header-bundle branch May 21, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants