Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel settings: CTA button and styling tweaks to image upload UI #1127

Closed
pdpinch opened this issue Aug 26, 2018 · 6 comments · Fixed by #1338
Closed

Channel settings: CTA button and styling tweaks to image upload UI #1127

pdpinch opened this issue Aug 26, 2018 · 6 comments · Fixed by #1338
Assignees

Comments

@pdpinch
Copy link
Member

pdpinch commented Aug 26, 2018

As a user, it needs to be a little clearer how and what I am supposed to upload for the channel appearance.

See https://invis.io/9EN908ZQPAX#/316069757_Channel_Settings_Appearance_Upload_Cover_Image

@noisecapella noisecapella removed their assignment Sep 14, 2018
@rhysyngsun
Copy link
Contributor

@pdpinch I think this is somewhat blocked by completion of the style refactor, right?

@pdpinch
Copy link
Member Author

pdpinch commented Sep 17, 2018

This is blocked by #1153

@pdpinch pdpinch removed the Blocked label Sep 19, 2018
@pdpinch pdpinch added this to the September Release milestone Sep 20, 2018
@alicewriteswrongs alicewriteswrongs self-assigned this Sep 27, 2018
@alicewriteswrongs
Copy link
Contributor

alicewriteswrongs commented Sep 27, 2018

what changes are related to this ticket, as opposed to #1203?

@pdpinch
Copy link
Member Author

pdpinch commented Oct 4, 2018

This issue was specifically about the text and button that appears after you click to add an avatar or a channel banner, i.e. the "drag and image here or click to select an image" part.

@alicewriteswrongs
Copy link
Contributor

@pdpinch question on this, currently we have a desktop and mobile photo upload message. the mobile one looks like this:

mobileversionffffjfjfj

I don't see a design for a mobile upload - should we just do a button, as in the design linked above, with 'Click to select an image' on it?

@pdpinch
Copy link
Member Author

pdpinch commented Oct 10, 2018 via email

alicewriteswrongs added a commit that referenced this issue Oct 10, 2018
This changes the text we display in the image upload dialog box, to
match what is on the mockups (see the linked issue).

closes #1127
pr #1338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants