Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the message shown in the image upload dialog box #1338

Merged
merged 1 commit into from Oct 10, 2018

Conversation

alicewriteswrongs
Copy link
Contributor

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

closes #1127

What's this PR do?

This changes the text we display in the image upload dialog box, to match what is on the mockups (see the linked issue).

How should this be manually tested?

Go to one of the image upload things, and make sure that you see something along the lines of the mockups there.

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #1338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1338   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         417      417           
  Lines       15137    15137           
  Branches      440      440           
=======================================
  Hits        14605    14605           
  Misses        477      477           
  Partials       55       55
Impacted Files Coverage Δ
static/js/components/ImageUploaderForm.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a82b3a...97c5ddf. Read the comment docs.

@noisecapella noisecapella self-assigned this Oct 10, 2018
This changes the text we display in the image upload dialog box, to
match what is on the mockups (see the linked issue).

closes #1127
pr #1338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel settings: CTA button and styling tweaks to image upload UI
4 participants