Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer links do not work #169

Closed
isaisabel opened this issue May 19, 2020 · 2 comments · Fixed by #193
Closed

Layer links do not work #169

isaisabel opened this issue May 19, 2020 · 2 comments · Fixed by #193
Assignees
@isaisabel
Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Milestone
Version 3.0: Webs...

Comments

@isaisabel
Copy link
Contributor

Links to view the layer on the NAvigator includes the domain twice. For example:

https://mitre-attack.github.io/attack-navigator/beta/enterprise/enterprise/#layerURL=

This is because the navigator instances in the config already specifies the domain URL, but the code still appends the domain suffix to the URL in the navigator macro:

https://github.com/mitre-attack/attack-website/blob/develop/attack-theme/templates/macros/navigator.html#L21

Removing the {{layer.domain}} suffix should fix the issue.

See also this commit for a manual patch fixing the built content: 36d72f6
@isaisabel isaisabel added bug Something isn't working timescale/imminent Ready to be assigned to developers labels May 19, 2020
@IanDavila IanDavila self-assigned this May 20, 2020
@IanDavila IanDavila mentioned this issue May 20, 2020
Merged
isaisabel added a commit that referenced this issue May 20, 2020
@isaisabel
Merge pull request #171 from mitre-attack/fix/#169-layer-links
0ca5a7b 
Fixing navigator layer links
@isaisabel isaisabel mentioned this issue Jun 17, 2020
Closed
@isaisabel isaisabel reopened this Jun 17, 2020
@isaisabel
Copy link
Contributor Author

Reopening so that this fix can be added to master and sub-techniques versions

@isaisabel isaisabel assigned isaisabel and unassigned IanDavila Jun 17, 2020
@isaisabel isaisabel mentioned this issue Jun 17, 2020
Merged
@isaisabel
Copy link
Contributor Author

fixed in v1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isaisabel isaisabel

Labels
bug Something isn't working timescale/imminent Ready to be assigned to developers
Projects
None yet
Milestone
Version 3.0: Website Modularization
Development

Successfully merging a pull request may close this issue.

fix layer link bug in master mitre-attack/attack-website
2 participants
@IanDavila @isaisabel