VIRTS-3315: Dependency Extractor #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current version (hoping to refine a bit more), can extract 117 dependencies from a total of 213 possible. |
|
Got coverage up to 179 out of 213 by tweaking a few things, but I'm not sure I'll be able to get many, if any, more. There's a sizeable number of tests that just tell the user to do something manually. |
uruwhy
reviewed
Dec 16, 2021
uruwhy
reviewed
Dec 16, 2021
added 2 commits
December 17, 2021 08:36
uruwhy
approved these changes
Dec 17, 2021
ArtificialErmine
changed the title
This was referenced Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a very basic dependency extractor for atomic abilities. Requires the atomic ability dependencies to be scripted in the original files; if not, the system will not expand the usual file produced to include dependency integration.
Type of change
How Has This Been Tested?
Locally, validating the generated files as reasonable given the inputs.
Checklist: