Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery import #4752

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Remove jQuery import #4752

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c8ebfc
Removed jQuery import
charleshu-8 Jul 26, 2023
94ca296
Merge branch 'master' into supportWarningjQuery
mergify[bot] Jul 26, 2023
0d6726e
Merge branch 'master' into supportWarningjQuery
mergify[bot] Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/frontend/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<script src="/static/export/jquery.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting find. So this wasn't needed in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem so. There are no jQuery calls in the file and running manual tests using IE and Javascript disabled give the same result with or without the jQuery import.

<link rel="icon" href="/favicon.ico">
<title>Heimdall</title>
</head>
Expand Down
Loading