Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery import #4752

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Remove jQuery import #4752

merged 3 commits into from
Jul 26, 2023

Conversation

charleshu-8
Copy link
Contributor

@charleshu-8 charleshu-8 commented Jul 26, 2023 •
edited
Loading

  • Removes jQuery import used in non-HTML Export files
  • Extension of Export HTML refactor

@charleshu-8
Removed jQuery import
1c8ebfc 
Signed-off-by: Charles Hu <chu@mitre.org>
@charleshu-8 charleshu-8 added heimdall-frontend Issue is related to the Heimdall-Lite frontend javascript Pull requests that update Javascript code labels Jul 26, 2023
@charleshu-8 charleshu-8 self-assigned this Jul 26, 2023
@charleshu-8 charleshu-8 changed the title Removed jQuery import Remove jQuery import Jul 26, 2023
@charleshu-8 charleshu-8 marked this pull request as ready for review July 26, 2023 19:26
Amndeep7
Amndeep7 requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested with IE? I think it might still be accessible via mbridge? Or maybe using Edge but forcing IE compatibility mode?

@charleshu-8
Copy link
Contributor Author

@Amndeep7 It has been tested on IE.

IE

em-c-rod
em-c-rod reviewed Jul 26, 2023
View reviewed changes
apps/frontend/public/index.html
@@ -5,7 +5,6 @@
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<script src="/static/export/jquery.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting find. So this wasn't needed in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem so. There are no jQuery calls in the file and running manual tests using IE and Javascript disabled give the same result with or without the jQuery import.

@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into master. label Jul 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mergify mergify bot merged commit 44cd63c into master Jul 26, 2023
20 checks passed
@mergify mergify bot deleted the supportWarningjQuery branch July 26, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em-c-rod em-c-rod em-c-rod left review comments

@Amndeep7 Amndeep7 Amndeep7 approved these changes

Assignees

@charleshu-8 charleshu-8

Labels
heimdall-frontend Issue is related to the Heimdall-Lite frontend javascript Pull requests that update Javascript code ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charleshu-8 @Amndeep7 @em-c-rod