Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to normalize export ckl profile name #5852

Merged
merged 8 commits into from
May 29, 2024
Merged

Add option to normalize export ckl profile name #5852

merged 8 commits into from
May 29, 2024

Conversation

georgedias
Copy link
Contributor

@georgedias georgedias commented May 23, 2024 •
edited

Provide a checkbox that normalizes (proper formats) the profile title (name). Also fixes issue # #2375

Example, if the name is: redhat-enterprise-linux-8-stig-baseline
It normalizes to: 'Redhat Enterprise Linux 8 Security Technical Implementation Guide`

Logic

Process exchanges profile titles that end with 'stig-baseline', 'cis-baseline', 'srg-baseline' to Security Technical Implementation Guide and capitalizes all preceding words removing the dashes.

Without applying title formatting:
image

After applying title formatting:
image

@georgedias
added option to normalize export ckl profile name
444d8d3 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias added the enhancement New feature or request label May 23, 2024
@georgedias
linter fixes
d19f8e2 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
code quality fixes
8c2da53 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias requested a review from DMedina6 May 23, 2024 23:31
@georgedias
code quality fixes
a5466bf 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
DMedina6
DMedina6 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@DMedina6 DMedina6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works as expected after testing, and tests all pass. I'm going to approve this even though I left other comments for review.

apps/frontend/src/components/global/ExportCKLModal.vue Outdated Show resolved Hide resolved
apps/frontend/src/components/global/ExportCKLModal.vue Outdated Show resolved Hide resolved
apps/frontend/src/components/global/ExportCKLModal.vue Show resolved Hide resolved
apps/frontend/src/components/global/ExportCKLModal.vue Show resolved Hide resolved
georgedias and others added 2 commits May 27, 2024 18:31
@georgedias
Update ExportCKLModal.vue
7145a00 
Review updates
@georgedias
review updates
d135922 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias added heimdall-frontend Issue is related to the Heimdall-Lite frontend ready-to-merge Used by mergify to identify if a PR is ready to merge into master. labels May 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mergify mergify bot merged commit e932e6d into master May 29, 2024
19 checks passed
@mergify mergify bot deleted the export-ckl-gui branch May 29, 2024 14:04
@DMedina6 DMedina6 restored the export-ckl-gui branch May 29, 2024 14:09
@georgedias georgedias deleted the export-ckl-gui branch May 29, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMedina6 DMedina6 DMedina6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request heimdall-frontend Issue is related to the Heimdall-Lite frontend ready-to-merge Used by mergify to identify if a PR is ready to merge into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgedias @DMedina6