Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for alignment in debug mode #35

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Check for alignment in debug mode #35

merged 1 commit into from
Sep 18, 2019

Conversation

skgbanga
Copy link
Contributor

No description provided.

@wjakob
Copy link
Member

wjakob commented Sep 17, 2019

This looks good, but one request: can you remove the assertions in dynamic.h? Here, checking seems a bit overkill given that allocations will be done with the new over-aligned new operator.

@skgbanga
Copy link
Contributor Author

@wjakob that's not always the case. Right now, my main use case involves

static Derived map(void *ptr, size_t size)

I am converting some existing code to start using enoki, so those checks still do help.

Upto you though. Personally I would prefer them, but can remove as well.

@wjakob
Copy link
Member

wjakob commented Sep 17, 2019

Hi @skgbanga ,

the right place to put the assertion would be in map() then, instead of all of the other dynamic array-related operations.

Best,
Wenzel

@skgbanga
Copy link
Contributor Author

@wjakob That makes sense to me.

Changes pushed.

@wjakob wjakob merged commit 6544b04 into mitsuba-renderer:master Sep 18, 2019
@wjakob
Copy link
Member

wjakob commented Sep 18, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants