Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux compilation broken b/c of missing <prctl.h> #34

Closed
amyspark opened this issue Oct 7, 2017 · 0 comments
Closed

Linux compilation broken b/c of missing <prctl.h> #34

amyspark opened this issue Oct 7, 2017 · 0 comments

Comments

@amyspark
Copy link
Contributor

amyspark commented Oct 7, 2017

As part of afd3a1c, a conditional include was removed from src/libcore/thread.cpp which is necessary for using prtcl() calls in Linux.

// Required for native thread functions
#if defined(__LINUX__)
# include <sys/prctl.h>
#elif defined(__OSX__)
# include <pthread.h>
#elif defined(__WINDOWS__)
# include <windows.h>
#endif

// Required for native thread functions
#if defined(__OSX__)
# include <pthread.h>
#elif defined(__WINDOWS__)
# include <windows.h>
#endif

It seems that there was a prctl call left behind:

prctl(PR_SET_NAME, threadName.c_str());

A pull request is forthcoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant