Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler plugins #187

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Sampler plugins #187

merged 2 commits into from
Jul 21, 2020

Conversation

Speierers
Copy link
Member

@Speierers Speierers commented Jun 22, 2020

Implementation of various sampler plugins

This PR provides implementation for various sampler plugins:

This PR also update the doc API.

@Speierers Speierers marked this pull request as draft June 22, 2020 14:44
@Speierers Speierers changed the title Various sampler plugins 🎲 Sampler plugins Jun 22, 2020
@Speierers Speierers marked this pull request as ready for review July 9, 2020 11:50
@Speierers Speierers force-pushed the samplers branch 2 times, most recently from 558c3f3 to 5af3036 Compare July 9, 2020 14:50
@Speierers Speierers requested a review from wjakob July 10, 2020 06:25
@Speierers Speierers changed the title Sampler plugins ✨ [New Feature] Sampler plugins Jul 15, 2020
@Speierers Speierers changed the title ✨ [New Feature] Sampler plugins Sampler plugins Jul 15, 2020
@Speierers Speierers added the ✨ new feature New feature or request label Jul 15, 2020
Copy link
Member

@wjakob wjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sébastien,

looks great, here are a few comments from me!

Best,
Wenzel

include/mitsuba/core/qmc.h Outdated Show resolved Hide resolved
include/mitsuba/core/qmc.h Outdated Show resolved Hide resolved
include/mitsuba/core/qmc.h Outdated Show resolved Hide resolved
include/mitsuba/core/qmc.h Outdated Show resolved Hide resolved
include/mitsuba/core/random.h Outdated Show resolved Hide resolved
src/samplers/orthogonal.cpp Outdated Show resolved Hide resolved
src/samplers/orthogonal.cpp Outdated Show resolved Hide resolved
src/samplers/orthogonal.cpp Outdated Show resolved Hide resolved
src/samplers/orthogonal.cpp Outdated Show resolved Hide resolved
src/samplers/orthogonal.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants