Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load config from JSON file #928

Closed
wants to merge 1 commit into from
Closed

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Dec 12, 2013

This implements issue #927 and allows us to load Flask config from JSON files that can be shared for example with frontend dev tools like grunt.

@untitaker
Copy link
Contributor

Isn't from_dict mostly the same as update?

@Turbo87
Copy link
Contributor Author

Turbo87 commented Dec 13, 2013

@untitaker you're totally right... I missed that Config was derived from dict. I'll rework the commits later today to use update() instead.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Dec 13, 2013

@untitaker as expected, it seems to work well with update() too. I've pushed the new from_jsonfile() commit and removed the from_dict() commit.

@mattupstate
Copy link
Contributor

@Turbo87 @untitaker This is a duplicate of #827

@Turbo87
Copy link
Contributor Author

Turbo87 commented Dec 22, 2013

@mattupstate you're right, I didn't see the other PR when I had a quick look if one already exists. Is there any chance this will be merged any time soon?

@Turbo87 Turbo87 closed this Dec 22, 2013
@untitaker
Copy link
Contributor

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants