-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the default global handler #141
Comments
That indeed sounds like a good move, specially if we want third party libs to start using Logbook more. As long as the docs are clear on those two use cases, I see no reason to go for it. Well thought @vmalloc! |
@brainstorm who else do we want to involve in this decision? I'm trying to avoid a massive rage once we bump a version with this change... |
Other than upstream's @mitsuhiko, who I guess is packed right now with other projects and decisions, I cannot think of anyone else... |
I posted a message in |
👍 |
@brainstorm why close the issue? |
Oops, sorry, my bad :-S |
So this one got in for 0.11 at the end, right? |
To 0.10. Forgot to close :-) |
This is a tough one.
One of the problems with Logbook today that is hindering its adoption is, in my opinion, the default global handler.
While very useful for quick apps or webapps, it is an annoyance to library developers -- each library explicitly or implicitly using Logbook means output to stderr by default.
Given the fact that setting up logbook is so easy (especially compared to
basicConfig
), I think dropping the default global handler is a wise move. Application seeking to add it back need a single line in theirif __name__ == 'main'
section, while libraries can rest assured that they don't litter the screen by default.However I won't go forward making the change before I hear some more opinions about it - @brainstorm or anyone else, please let me know what you think...
The text was updated successfully, but these errors were encountered: