Feat: add cronjob update #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ken due to required tag conflicting for creation and update processes
This comment was marked as outdated.
This comment was marked as outdated.
…ture/cronjob-update
martin-helmich
requested changes
Aug 28, 2024
…reter properly and handle empty changes more politely
martin-helmich
requested changes
Aug 29, 2024
martin-helmich
requested changes
Sep 3, 2024
…is overstepped and overall optimise code
…ture/cronjob-update
martin-helmich
requested changes
Sep 4, 2024
Co-authored-by: Martin Helmich <m.helmich@mittwald.de>
…n and fix check timeout
…ture/cronjob-update # Conflicts: # src/commands/cronjob/update.tsx
niristius
commented
Sep 4, 2024
src/commands/cronjob/create.tsx
Outdated
| const cronjobCreationData: CronjobCreationData = { | ||
| appId: appInstallationId, | ||
| active: !disable, | ||
| description, | ||
| interval, | ||
| email, | ||
| destination, | ||
| timeout: timeout.seconds, | ||
| }; | ||
|
|
||
| const { id: cronjobId } = await p.runStep("creating cron job", async () => { | ||
| const r = await this.apiClient.cronjob.createCronjob({ | ||
| projectId, | ||
| data: cronjobCreationData, | ||
| data: { | ||
| appId: appInstallationId, | ||
| active: !disable, | ||
| description, | ||
| interval, | ||
| email, | ||
| destination: buildCronjobDestination(url, command, interpreter), | ||
| timeout: timeout.seconds, | ||
| }, |
There was a problem hiding this comment.
For some reason I was under the impression that if a key has an undefined value, currently set values for conjobs (or whichever entity is being updated) will be overwritten, I played around for a bit and it seems to not be the case wich makes this approach the most concise.
martin-helmich
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.