New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we don't bind the wrong this #3

Merged

ttacon merged 1 commit into master from make-sure-we-dont-bind-the-wrong-this

Aug 19, 2016

Contributor

ttacon commented Aug 19, 2016

No description provided.


          Make sure we don't bind the wrong this

344146e

ttacon merged commit 0d5230c into master

ttacon deleted the make-sure-we-dont-bind-the-wrong-this branch

August 19, 2016 15:06

wearhere reviewed

View reviewed changes

index.js

-                  setInterval(this._sendMetrics, this.options.sendInterval);
+                if (self.options.enabled) {
+                  setInterval(() => {
+                    self._sendMetrics();

Contributor

wearhere Aug 19, 2016

Using an arrow function here would actually allow you to use this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment