Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pioneer DDJ-400: Controller Manual #331

Merged
merged 20 commits into from
Jan 31, 2021

Conversation

jusko
Copy link
Contributor

@jusko jusko commented Dec 23, 2020

Manual Documentation for Pioneer DDJ-400 mappings from mixxxdj/mixxx#3479

  • General info
  • Browser mappings
  • Deck mappings
  • Mixer mappings
  • Effects mappings
  • Padmode documentation
  • Sampler documentation

@jusko jusko marked this pull request as draft December 23, 2020 15:37
@Be-ing
Copy link
Contributor

Be-ing commented Dec 23, 2020

Thanks again for picking up this work!

@Be-ing
Copy link
Contributor

Be-ing commented Dec 24, 2020

If you are able to test which sound API works best with a computer running Windows, that would be helpful to document. Unfortunately I'm not sure you could really evaluate that with a virtual machine. If you don't have access to a computer running Windows, don't worry about it.

@Be-ing
Copy link
Contributor

Be-ing commented Dec 25, 2020

I think the pad mode sections should be made subsections of the Deck section. Other than that, this documentation looks good to me and we can move onto the code. :)

@Holzhaus
Copy link
Member

If you're using Inkscape, can you save the SVG files as "Optimized SVG" to reduce the file size?

@jusko
Copy link
Contributor Author

jusko commented Dec 26, 2020

If you are able to test which sound API works best with a computer running Windows, that would be helpful to document. Unfortunately I'm not sure you could really evaluate that with a virtual machine. If you don't have access to a computer running Windows, don't worry about it.

Unfortunately only have a VM for basic Windows testing

@jusko jusko marked this pull request as ready for review December 26, 2020 06:41
@jusko
Copy link
Contributor Author

jusko commented Dec 26, 2020

Many thanks for the review on this @Be-ing, @Holzhaus!

The last commit updates a few unrelated links that were broken. There's still a problem with the appendix's twitter url for whatever reason. 🤷‍♂️

@Holzhaus
Copy link
Member

The last commit updates a few unrelated links that were broken. There's still a problem with the appendix's twitter url for whatever reason. 🤷‍♂️

I appreciate the effort, but please remove that commit. There's already #332 awaiting review and PRs shouldn't contain unrelated changes if possible.

@Be-ing
Copy link
Contributor

Be-ing commented Jan 21, 2021

ping @jusko could you update this with the recent effects changes?

@jusko
Copy link
Contributor Author

jusko commented Jan 21, 2021

ping @jusko could you update this with the recent effects changes?

Sure thing. On the road atm, will update on the weekend.

@Holzhaus
Copy link
Member

Holzhaus commented Jan 30, 2021

@jusko Could you open the SVGs in Inkscape and saves them as "Optimized SVGs" to reduce the file size?

@Be-ing is everything else in order or does the need another round of reviewing?

@jusko
Copy link
Contributor Author

jusko commented Jan 30, 2021

@jusko Could you open the SVGs in Inkscape and saves them as "Optimized SVGs" to reduce the file size?

Done in 5008d46 @Holzhaus 👍

@jusko
Copy link
Contributor Author

jusko commented Jan 30, 2021

Just a note to update the wiki page with a link to the manual when this is merged.

@Be-ing Be-ing merged commit 8ef1078 into mixxxdj:2.3 Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants