Pioneer DDJ-400: Address outstanding issues #3479
Conversation
|
Thanks for continuing this! Please fix the pre-commit issues. You can download the patch as an artifact from the GH Actions job. To prevent more issues going forward, set up pre-commit locally. |
|
If I'm not mistaken this PR is based on the 2.2 branch and can already be part of the 2.2.5 release. |
|
There will be no 2.2.5 release. We don't have working 2.2 build servers anymore. |
|
Updated the PR description to summarise the remaining discussion. Also a bit confused about the base branch: could you confirm if I should rebase onto |
|
No, just leave it on 2.2. There are no conflicts and no unrelated commits in this PR, so there's no reason to rebase. We can safely merge it into the 2.2 branch and it well end up in 2.3 anyway, regardless of whether we make a 2.2.5 release or not. |
|
I'm going through each control, one at a time, as I write up the manual. Catching some further issues which I'll add to the list in the description... |
|
Quite a few little fixes made during QA (while writing the manual). The FX workflow is also improved, and the biggest change: the three experimental pad modes dropped. Also moved the code around so that it is logically structured in the same way as the controller (which makes it a bit easier to maintian, for me at least). Will keep testing it as I get mixxx setup on a Pi 😉 |
Off-topic |
- Removes getters & setters with side effects - Uses callbacks to keep the FX light in sync when changes are made through the UI
Co-authored-by: Be <be.0@gmx.com>
Relies solely on <outputs> for lighting up the required pads in beatjump mode. This removes the need to track the controllers padmode in the script. This is desirable, because the controller tracks the padmode in its firmware and seems to be susceptible to benign but unexpected behavior when that process is interfered with (e.g., manually resetting the padmode lights sometimes prevents the next pad mode from being enabled until a sequence of other buttons are pressed).
jusko
force-pushed
the
pioneer_ddj_400
branch
from
d794566
to
f4a9283
Compare
Done 👍 |
|
All green 👍 |
| // * Mixxx mapping script file for the Pioneer DDJ-400. | ||
| // * Authors: Warker, nschloe, dj3730, jusko | ||
| // * Reviewers: Be-ing, Holzhaus | ||
| // * Manual: https://manual.mixxx.org/2.3/en/hardware/controllers/pioneer_ddj_400.html |
There was a problem hiding this comment.
Should we remove the /en/ part of the URL? I guess a redirect (301) will add this implicitly.
|
Thanks for bearing with this review @jusko! I am glad this is finally done. I am glad we came up with something useful and usable for the limited and odd effects controls on this controller. |
|
Thanks also by me @jusko! Finally, this long-standing project is coming to a close. My DDJ-400 works better than ever! 🚀 |
|
@ywwg Considering the popularity of this controller we could publish a short message on our blog and forward to social media. We need to mention that it is only available in the beta. Another chance to get more beta testers on board ;) |
All thanks to the work you, @dj3730 and Warker (the originator) put in @nschloe. Organic open source evolution ftw! 🙂
Really appreciate a thorough review @Be-ing. 👍 Thank you and @Holzhaus for all of your time and help. |
noted! |
|
@jusko Can you write a short paragraph describing the updates? I see the bullet points above but I don't know all of the context |
|
There was no DDJ-400 support before this so there aren't really any updates to describe. |
|
ah ok it sounded like it was updates to existing support. I'd still appreciate a short summary that I can cut and paste rather than try to deduce the major achievements / limitations |
|
Instead of highlight features of this particular controller, you could maybe just make a blogpost saying that Mixxx 2.3 will add ootb support for popular controllers such as the Pioneer DDJ-200, Pioneer DDJ-400, Native Instruments Traktor S3, ...? |
|
Including links to the manual pages for quick reference. |
|
sounds good! |
|
Hay fellas! I am using mixxx 2.3.0 on Ubuntu 20.04.2 with Pioneer DDJ-400 controller and I am very happy with both the software and the hardware. The mapping is awesome too - thanks to everyone involved! I am trying to find a way to enable vinyl break, like it can be configured in Serato in order to perform this: I checked on various repositories, mixxx forums and launchpad and this pull request is the closest thing, that I found: Do you have any info on how this can be scripted as advised from Mixxx designer here: Or perhaps where I can submit such feature request? |
Todo
Done
Addressing the review comments in #2403:
Implement outstanding PAD-FX(Not much that can really be added here at the moment)Issues picked up in Q/A Testing
BEAT SYNCdoes not work in the same way as clicking on the software control.<and>Xmas presents (if there's time) 🎅
BEAT FXmappingsPending Further Discussion
Drop or reimplement all secondary pad mode features in the discussion
In short, the controller has 4 primary pad modes (
HOT CUE,BEAT LOOP,BEAT JUMPandSAMPLER) and 4 secondary (i.e, shifted) pad modes (KEYBOARD,PAD FX1,PAD FX2andKEY SHIFT).The primary pad modes are fully implemented and work well.
The secondary pad modes are not production quality and are the results of proof of concept prototypes. They either need to be rewritten or dropped.
Make FX workflow a bit more intuitive
A single knob on the controller is switched between wet/dry mix and metaknob mappings.
Currently it is:
It is more intuitive to:
Documentation* 📝
PR for the manual is