-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run make gettext and add new/modified files #458
Conversation
There are a whole bunch of broken links in the manual... should I fix / remove those here or can we address it later? (I'd prefer to do this incrementally) |
Most of those seem to be false positives. Either because some conncections actually seem to block us (403) or because there is some subtle TLS error. All of the links do actually work in the browser. |
Mm, can we add them to a kind of ignore list? |
I have never worked with this check so I will have to find some time to figure out what options it takes |
(alternatively, we can ignore it for this PR and file a bug) |
More importantly though, who can review this PR? I've never ran this command so I assume it just updates the translation files? So we can basically merge without looking at them, right? |
IIRC @esbrandt is the translations expert. |
Here is the guide for our mixxx repro. I think the same workflow applies here as well. I can do this here as well. And we can close this PR. |
I had to run this command to get the manual to pick up my new controller file, and it made all these other updates too |
Is there something else I should have done in my other PR to get the build system to see my new file? quote: Update source translationsFor every change to the manual source files (.rst) the source translation files
|
Ah, yes I see the steps are described here: I think you should do everything step by step. I think you can also push directly, too keep transiflex and the manual repository in sync. Do you have sufficient rights at transiflex?
You can already see your new file in the deploy preview: |
This is not necessary. With a clean build dir, the new controller documentation is included. It probably makes sense to update the translations because they are old, but it's not necessary for building the manual. |
ok, closing this |
No description provided.