Skip to content

Commit

Permalink
ChannelMixer: remove enormous autogenerated code
Browse files Browse the repository at this point in the history
Previously, the autogenerated code allowed for a vectorizing
optimization by combining gain application (channel faders +
crossfader) with channel mixing. When postfader effects were
implemented in Mixxx 2.1 (PR #1254), these two operations
had to be decoupled to process effects between gain
application and channel mixing. Therefore, the
autogenerated code lost its advantage and became an
overcomplication.
  • Loading branch information
Be-ing committed Oct 24, 2020
1 parent f42f5e8 commit 0a5a203
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 14,543 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ add_library(mixxx-lib STATIC EXCLUDE_FROM_ALL
src/engine/cachingreader/cachingreader.cpp
src/engine/cachingreader/cachingreaderchunk.cpp
src/engine/cachingreader/cachingreaderworker.cpp
src/engine/channelmixer_autogen.cpp
src/engine/channelmixer.cpp
src/engine/channels/engineaux.cpp
src/engine/channels/enginechannel.cpp
src/engine/channels/enginedeck.cpp
Expand Down
2 changes: 1 addition & 1 deletion build/depends.py
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ def sources(self, build):
"src/engine/sidechain/networkoutputstreamworker.cpp",
"src/engine/sidechain/networkinputstreamworker.cpp",
"src/engine/enginexfader.cpp",
"src/engine/channelmixer_autogen.cpp",
"src/engine/channelmixer.cpp",
"src/engine/positionscratchcontroller.cpp",
"src/engine/controls/bpmcontrol.cpp",
"src/engine/controls/clockcontrol.cpp",
Expand Down
Loading

0 comments on commit 0a5a203

Please sign in to comment.