Pref Mixer: avoid redundant calls to widget update slots

mixxxdj · Jun 28, 2023 · 5ccbfc0 · 5ccbfc0
1 parent 94c1fb8
commit 5ccbfc0
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/preferences/dialog/dlgprefmixer.cpp b/src/preferences/dialog/dlgprefmixer.cpp
@@ -77,10 +77,6 @@ DlgPrefMixer::DlgPrefMixer(
           m_initializing(true) {
     setupUi(this);
 
-    setUpMainEQ();
-
-    slotUpdate();
-
     // Update the crossfader curve graph and other settings when the
     // crossfader mode is changed or the slider is moved.
     connect(SliderXFader,
@@ -161,6 +157,10 @@ DlgPrefMixer::DlgPrefMixer(
             this,
             &DlgPrefMixer::slotPopulateQuickEffectSelectors);
 
+    setUpMainEQ();
+
+    slotUpdate();
+
     m_initializing = false;
 
     // This applies the Main EQ and saves default values of previously missing
@@ -417,8 +417,6 @@ void DlgPrefMixer::setDefaultShelves() {
             getSliderPosition(250,
                     SliderLoEQ->minimum(),
                     SliderLoEQ->maximum()));
-    slotLoEqSliderChanged();
-    slotHiEqSliderChanged();
 }
 
 void DlgPrefMixer::slotResetToDefaults() {
@@ -809,8 +807,6 @@ void DlgPrefMixer::slotUpdate() {
                 getSliderPosition(lowEqFreq,
                         SliderLoEQ->minimum(),
                         SliderLoEQ->maximum()));
-        slotLoEqSliderChanged();
-        slotHiEqSliderChanged();
     }
 
     CheckBoxInstantMainEQ->setChecked(m_instantMainEq);